Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thumbnail generation method on video recording #914

Merged

Conversation

ArturoManzoli
Copy link
Contributor

  • Added a try-catch routine
  • Removed redundant blob processing

Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Code looks good and it's working fine here.

@rafaellehmkuhl rafaellehmkuhl merged commit d25c729 into bluerobotics:master Apr 26, 2024
8 checks passed
@ArturoManzoli ArturoManzoli deleted the 877-fix-thumbnail-extraction branch May 24, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants