New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update_freebuoyancy_gazebo9 #1
Update_freebuoyancy_gazebo9 #1
Conversation
Hi @alexandrechamand thank you for your contributions, I'll try to test it before the merge. |
Hi @alexandrechamand, did you update this patch for Gazebo 10 as well? |
Hi there, I just updated it for Gazebo 9, I didn't test it on Gazebo 10
version, I have a look on it ASAP :)
Le sam. 14 déc. 2019 à 08:34, Russ <notifications@github.com> a écrit :
… Hi @alexandrechamand <https://github.com/alexandrechamand>, did you
update this patch for Gazebo 10 as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=ALMTOKA3NICNYH7JXHGHYVTQYSEA5A5CNFSM4GYVSAJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG34NVI#issuecomment-565692117>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALMTOKE725CXY267YKSSNJTQYSEA5ANCNFSM4GYVSAJQ>
.
|
Thanks for this @alexandrechamand. This is on my todo list. |
Hello Russ, I just checked on Gazebo 10, everything is working fine :)
Le dim. 12 janv. 2020 à 01:20, Russ <notifications@github.com> a écrit :
… Thanks for this @alexandrechamand <https://github.com/alexandrechamand>.
This is on my todo list.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=ALMTOKFYZIEULVVIZZNXTNDQ5JO5FA5CNFSM4GYVSAJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWOGJQ#issuecomment-573367078>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALMTOKCW2FAU2QOWTNQQR2LQ5JO5FANCNFSM4GYVSAJQ>
.
|
Hello @alexandrechamand. Excellent. Thanks again! |
@alexandrechamand can you rebase this PR over the last version of master branch ? |
Hi there ! this is an update of freebuoyancy for gazebo9
8a27e14
to
17a43c7
Compare
Just made it
Le mer. 22 janv. 2020 à 13:01, Patrick José Pereira <
notifications@github.com> a écrit :
… @alexandrechamand <https://github.com/alexandrechamand> can you rebase
this PR over the last version of master branch ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=ALMTOKB7RMPJ5A5KMGA6BXTQ7AYS7A5CNFSM4GYVSAJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJTJS5A#issuecomment-577149300>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALMTOKDAQCNQ4NRB2N7LSO3Q7AYS7ANCNFSM4GYVSAJQ>
.
|
Well that makes my job easier. 🎉 |
This change comes in the nick of time for my team. Thank you! |
Hi ! I updated your code with the new library of gazebo9. "gazebo/math" it's not working anymore and merge into "ignition/math", some of the physics engine went directly to the world class and some name like "GetModelCount" it's now "ModelCount". You'll see all the changes in the commit :)
Cheers,
Alex