Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update_freebuoyancy_gazebo9 #1

Merged

Conversation

alexandrechamand
Copy link

Hi ! I updated your code with the new library of gazebo9. "gazebo/math" it's not working anymore and merge into "ignition/math", some of the physics engine went directly to the world class and some name like "GetModelCount" it's now "ModelCount". You'll see all the changes in the commit :)

Cheers,
Alex

@patrickelectric
Copy link
Member

Hi @alexandrechamand thank you for your contributions, I'll try to test it before the merge.

@russkel
Copy link

russkel commented Dec 14, 2019

Hi @alexandrechamand, did you update this patch for Gazebo 10 as well?

@alexandrechamand
Copy link
Author

alexandrechamand commented Jan 11, 2020 via email

@russkel
Copy link

russkel commented Jan 12, 2020

Thanks for this @alexandrechamand. This is on my todo list.

@alexandrechamand
Copy link
Author

alexandrechamand commented Jan 22, 2020 via email

@russkel
Copy link

russkel commented Jan 22, 2020

Hello @alexandrechamand. Excellent. Thanks again!

@patrickelectric
Copy link
Member

@alexandrechamand can you rebase this PR over the last version of master branch ?

Hi there ! this is an update of freebuoyancy for gazebo9
@alexandrechamand
Copy link
Author

alexandrechamand commented Jan 22, 2020 via email

@patrickelectric patrickelectric merged commit d1b2665 into bluerobotics:master Jan 22, 2020
@russkel
Copy link

russkel commented Jan 22, 2020

Well that makes my job easier. 🎉

@ForrestBarnes
Copy link

This change comes in the nick of time for my team. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants