Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping1d: support auto firmware baudrate detection #33

Merged
merged 2 commits into from Feb 10, 2022

Conversation

ES-Alexander
Copy link
Contributor

Relevant to #29

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did some tests in the pass and this turn out to be not reliable, did you check with a normal arduino , did it work every single time or when both Arduino and Ping got powered on simultaneously ?

@ES-Alexander
Copy link
Contributor Author

ES-Alexander commented Feb 10, 2022

did you check with a normal arduino , did it work every single time or when both Arduino and Ping got powered on simultaneously ?

For peace of mind, I just tried it >5 times in an Arduino Uno (unplugging the Arduino each time, so both devices get power at the same time), then a few times with the comms wires unplugged initially and then plugged in once the serial monitor was getting data. I then tried the same tests on a Mega 2560 clone, with both software and hardware serial, including testing 115200 for hardware serial as well. No issues on any of the tests - seems to be super robust on my end.

Edit: Just did some extra tests - it also works consistently at both 9600 and 115200 baud on the Feather M4 Express (SAMD). Only hardware serial, because software serial isn't supported for SAMD architectures.

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@patrickelectric patrickelectric merged commit e1fae3e into master Feb 10, 2022
@ES-Alexander ES-Alexander deleted the support-auto-firmware branch February 10, 2022 11:14
@ES-Alexander ES-Alexander mentioned this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants