pingmessage: performance improvements #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Helps with #101 (although Python's I/O can't really ever be completely as fast as compiled code). |
patrickelectric
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
It looks ok to me, I would just recommend to break the commit in multiple commits since there is a couple of things that are changing to improve performance, but they are not totally clear.
An example of commit organization:
- Change sum algorithm to built-in function
- Use
__slots__declaration to improve access speed- Reason, why, when and etc
- Break parser logic into a callback dictionary
- Reason, why and etc
- Change comparison from
isto==since...
ping @Williangalvani
Reduces memory overhead (no internal __dict__), and improves variable access speeds.
…ple of callbacks Swaps up to 11 conditionals per byte with a consistent single tuple index and function call.
patrickelectric
approved these changes
Jul 29, 2021
|
|
thanks for the updates!
patrickelectric
added a commit
to patrickelectric/ping-python-1
that referenced
this pull request
Nov 30, 2021
This should be zero and not one, the error was introduced in a rework on bluerobotics#110: https://github.com/bluerobotics/ping-python/pull/110/files#diff-ed2c04d88418d534a1ae078d8a994d08848d370ca71de0d0af5ab5f7b6f19d99R345 Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
added a commit
that referenced
this pull request
Nov 30, 2021
This should be zero and not one, the error was introduced in a rework on #110: https://github.com/bluerobotics/ping-python/pull/110/files#diff-ed2c04d88418d534a1ae078d8a994d08848d370ca71de0d0af5ab5f7b6f19d99R345 Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to 27% faster for Ping360 on 2M baud serial connection
calculate_checksumto use built insuminstead of manual loop__slots__toPingParserparse_byteto directly call the relevant function for the current stateERRORstatus code to be in line with ping-cpp