Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mac monterey #1031

Merged
merged 2 commits into from Jan 4, 2022
Merged

Fix mac monterey #1031

merged 2 commits into from Jan 4, 2022

Conversation

patrickelectric
Copy link
Member

@patrickelectric
link: filelink: Add isWritable function
fa5bb2e 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
link: filelink: Use new isWritable function implementation
b4ed4cd 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
Copy link
Member Author

Tested and working.

@patrickelectric
Copy link
Member Author

ping @ES-Alexander, @Williangalvani

Williangalvani
Williangalvani approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@Williangalvani Williangalvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this, but the code looks good.

@patrickelectric patrickelectric merged commit 1c2afec into bluerobotics:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Williangalvani Williangalvani Williangalvani approved these changes

@ES-Alexander ES-Alexander Awaiting requested review from ES-Alexander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to write files on mac monterey
2 participants
@patrickelectric @Williangalvani