examples: decode: improve recovery failure message #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Track number of bytes skipped during the recovery process, and include them in the output on failure.
ES-Alexander
force-pushed
the
improve-python-decoder
branch
from
ebd2301
to
4971c44
Compare
patrickelectric
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track number of bytes skipped during the recovery process, and include them in the output on failure.
Should help with understanding whether a large proportion of the file was lost, and whether a more in-depth recovery attempt / investigation is warranted.
Created because of this forum post, where the user was thinking the "recovery" portion was likely at/near the end of the file.