sensor: ping360: Improve test to check for firmware version over 3.3.0 #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newer firmwares come with async mode Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
| if (_commonVariables.deviceInformation.firmware_version_major == 3 | ||
| && _commonVariables.deviceInformation.firmware_version_minor == 3 | ||
| && _commonVariables.deviceInformation.firmware_version_patch == 1) { | ||
| if (version > QVersionNumber(3, 3, 0)) { |
There was a problem hiding this comment.
Wait, we changed here from 3.3.1 to 3.3.0!
@patrickelectric
There was a problem hiding this comment.
I prefer doing > over >=
There was a problem hiding this comment.
hmm, it was ==, not >=. Is this okay?
There was a problem hiding this comment.
That's the intended behavior, the async feature is only available on newer firmware, that are newer than 3.3.0, it started on 3.3.1
joaoantoniocardoso
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer firmware versions come with async mode