esp8266 host DFU example #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdlauer
reviewed
Jan 31, 2023
…ather than a more unusual compiler error
…ple doesn't presently build for ESP32. this will be addressed in a future PR.
…unning as the blues user.
zfields
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Is this empty, or is the diff bad?
| .pio | ||
| .vscode/.browse.c_cpp.db* | ||
| .vscode/c_cpp_properties.json | ||
| .vscode/launch.json |
There was a problem hiding this comment.
If we are discriminating on files, then I'm not sure why we are choosing this one. launch.json is the configuration for debugging.
Maybe the better question is, do we actually want anything from the .vscode/ folder?
There was a problem hiding this comment.
I know this is PlatformIO boilerplate, but it feels odd to have it, especially since we are not following this guidance (e.g. main.h).
There was a problem hiding this comment.
Another empty looking README.md
| .pio | ||
| .vscode/.browse.c_cpp.db* | ||
| .vscode/c_cpp_properties.json | ||
| .vscode/launch.json |
| @@ -0,0 +1,44 @@ | |||
| simplify ino file - remove boilerplate, implementation details to the shared DFU code | |||
There was a problem hiding this comment.
Maybe add a heading that states, "Change List:"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.0.0.0 is the ESP32 version ported to ESP8266
v1.1.0.0 experimental refactored version with the aim of separating the shared code from the device-specific code, which makes porting easier.