Skip to content

Commit

Permalink
Fix tacent lib using GIT_TAG to get the sse2 version of LibKTX. Print…
Browse files Browse the repository at this point in the history
… the full GLAD version string as a help-mark in the About dialog -- the GLAD full version string was too long to comfortably fit in the dialog window.
  • Loading branch information
bluescan committed Jul 16, 2024
1 parent 8f23f79 commit 1c516b2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ FetchContent_Declare(
tacent
GIT_REPOSITORY https://github.com/bluescan/tacent.git
# GIT_TAG v0.8.17
# GIT_TAG ec86775e058e21461e0e2e5e995940744b6ecc57
GIT_TAG 7ac84ececd755d38eb42e24ec4e1b8bdeb5698c5
)
FetchContent_MakeAvailable(tacent)

Expand Down
9 changes: 5 additions & 4 deletions Src/Dialogs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,11 @@ void Viewer::ShowAboutPopup(bool* popen)
ImGui::Text("Tacent Library V %d.%d.%d", tVersion::Major, tVersion::Minor, tVersion::Revision);
ImGui::Text("Dear ImGui V %s", IMGUI_VERSION);

// This way of getting the version is 'dynamic'. It will, for example, print mesa compatibility mode if it's being used.
ImGui::Text("GLAD V %s", glad_glGetString(GL_VERSION));
// This is the more 'static' way. Currently unused.
// ImGui::Text("GLAD V %d.%d", GLVersion.major, GLVersion.minor);
// This is the more 'static' way of getting the GLAD version. The full 'dynamic' version string can be quite
// long (especially in compatibility mode) and is presented with a help-mark (if user hovers over it).
ImGui::Text("GLAD V %d.%d", GLVersion.major, GLVersion.minor);
ImGui::SameLine();
Gutil::HelpMark((const char*)glad_glGetString(GL_VERSION));

ImGui::Text("GLFW V %d.%d.%d", glfwMajor, glfwMinor, glfwRev);
ImGui::Text("Ico Load");
Expand Down

0 comments on commit 1c516b2

Please sign in to comment.