Custom feeds #1001

dholms · 2023-05-08T18:54:47Z

No description provided.

roj1512 · 2023-05-08T19:17:55Z

Here’s a nicer emoji for WIP: 🚧

lexicons/app/bsky/feed/generator.json

* Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com>

* implement some starter bsky algos * add team dids * tidy * add quotepost check to whats hot classic * tests * carve out feedgen section of pds * apply limits * add describeFeedGenerator route * Whats hot new (#1060) * map out new whats hot * only available in postgres * Fix dev env public url (#1058) * Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com> * add defs for feed gen prefs & decrease displayName length * build branch * updated how saved feeds works * build algos branch * remove relative imports to @atproto/api * update hot classic name * rm build --------- Co-authored-by: Paul Frazee <pfrazee@gmail.com>

aliceisjustplaying · 2023-05-18T23:03:54Z

packages/pds/src/feed-gen/whats-hot.ts

+  // T = time since submission (in hours)
+  // G = Gravity, defaults to 1.8 in news.arc
+
+  const computeScore = sql<number>`${ref(


ok can i just say i love this it's so obvious in hindsight and yet. i am so excited about this one

hahaha yes 😁

devinivy · 2023-05-18T23:39:37Z

packages/pds/src/feed-gen/bsky-team.ts

+    .whereNotExists(accountService.mutedQb(requester, [ref('post.creator')]))
+    .whereNotExists(graphService.blockQb(requester, [ref('post.creator')]))


May just be missing a fine detail on this— but is the mute and block filtering necessary in our custom algos? I ask because I expected the user's PDS to do the work to filter-out bad results in getFeed (or at least the private mutes).

not necessary, but you could get smaller pages without this

basically blocked/muted posts will count against the pagination

feed gens should probably be encouraged to take blocks into account (tho obvs not required)

devinivy · 2023-05-19T21:49:41Z

packages/pds/src/feed-gen/with-friends.ts

+import { AlgoHandler, AlgoResponse } from './types'
+import { FeedKeyset } from '../app-view/api/app/bsky/util/feed'
+
+const handler: AlgoHandler = async (


There's a TODO on this one to sort out an issue it has when running with sqlite.

* actor type in profiles * skeleton lex * more schemas * first pass at feed composition * cleanup services * more tidying * fix up tests * bookmarking schemas * make feeds records instead of actors * some cleanup * fleshing out feeds as records * wip * working into cfg & dev-env * fix appview test util * bookmarking + views * tidy * add displayName * db migration * wip test * blob processing * first test working! * Sync-up snapshots * wip * Fix pds ctx type * Sync lexicons on pds and api * wip * fully refactor * Prep for open union in reply data in bsky appview, sync-up snapshots * msgs & ports * Make pds did cache sqlite-friendly * Start scaffolding more feedgen tests * revamp appview tests * revamp pds tests * merge in dev env utils * ensure plc close * add feed gen to dev-env * second feed gen * named feeds in mock * fix issue with dev-env pds appview * update bsky snaps * Flesh-out some feed gen tests * Fix feed gen reply test * Test feed bookmarking * update skeleton defs * merge * Sync-up pds with updated feed skeleton contract * Fix feed bookmark viewer state * add feed embeds * Test inaccurate feed gen repost * Tighten some error behaviors around feed gens * generator view in record embed * test * bookmarked/subscribed -> saved * updated snaps * name & descript on alices feed * add like counts * proposed lex * tweak * fetch feed generator details * add describeFeedGen to dev-env * adds tests for getFeedGenerator * Update lexicons/app/bsky/feed/getFeedGenerator.json Co-authored-by: devin ivy <devinivy@gmail.com> * update describe * add cid to feed gen view * add alice feed gen avatar * generator displayName required * update snaps * Fix dev env public url (bluesky-social#1058) * Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com> * add defs for feed gen prefs & decrease displayName length * build branch * updated how saved feeds works * cleanup lex * mount route * Starter bsky algos (bluesky-social#1046) * implement some starter bsky algos * add team dids * tidy * add quotepost check to whats hot classic * tests * carve out feedgen section of pds * apply limits * add describeFeedGenerator route * Whats hot new (bluesky-social#1060) * map out new whats hot * only available in postgres * Fix dev env public url (bluesky-social#1058) * Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com> * add defs for feed gen prefs & decrease displayName length * build branch * updated how saved feeds works * build algos branch * remove relative imports to @atproto/api * update hot classic name * rm build --------- Co-authored-by: Paul Frazee <pfrazee@gmail.com> * v0.3.6 * v0.3.7 * v0.1.10 * update name of skyline * build branch * aws build * getFeedGenerators test * For now only use new replyRef union for custom feeds, for compat * Don't use replyRef union on new feeds yet --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: Paul Frazee <pfrazee@gmail.com>

actor type in profiles

7941e1e

dholms marked this pull request as draft May 8, 2023 18:54

dholms force-pushed the custom-feeds branch from 0d6e909 to 7941e1e Compare May 8, 2023 22:28

dholms added 7 commits May 8, 2023 18:26

skeleton lex

b37bd06

more schemas

9a05145

first pass at feed composition

d97e79e

cleanup services

82c9e74

more tidying

04c5890

fix up tests

e007507

bookmarking schemas

a7b9e04

dholms mentioned this pull request May 9, 2023

Bring your own DID #1011

Merged

make feeds records instead of actors

7af005c

dholms commented May 10, 2023

View reviewed changes

lexicons/app/bsky/feed/generator.json Outdated Show resolved Hide resolved

dholms commented May 10, 2023

View reviewed changes

lexicons/app/bsky/feed/generator.json Outdated Show resolved Hide resolved

dholms added 15 commits May 10, 2023 14:43

some cleanup

3d472a2

fleshing out feeds as records

4aadec1

wip

06914dc

working into cfg & dev-env

de97b20

merge service auth & fix build

0f0efcb

fix appview test util

6edd506

Merge branch 'service-auth-tidy' into custom-feeds

a351aad

bookmarking + views

8be7529

tidy

7ec7096

add displayName

f23c20f

db migration

7805578

wip test

ba726c5

blob processing

654727b

first test working!

e73633b

merge main

4954cbf

dholms and others added 4 commits May 17, 2023 21:45

Merge branch 'main' into custom-feeds

8134b5c

Fix dev env public url (#1058)

900e91d

* Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com>

add defs for feed gen prefs & decrease displayName length

73d766b

build branch

87749b3

dholms marked this pull request as ready for review May 18, 2023 17:57

dholms and others added 5 commits May 18, 2023 13:16

updated how saved feeds works

df934b7

cleanup lex

ef52c70

mount route

1bfd214

v0.3.6

45c629b

aliceisjustplaying reviewed May 18, 2023

View reviewed changes

dholms added 4 commits May 18, 2023 18:09

Merge branch 'main' into custom-feeds

eea4bdf

v0.3.7

7fc4da6

v0.1.10

3cb9a5d

update name of skyline

4102fef

devinivy reviewed May 18, 2023

View reviewed changes

dholms and others added 4 commits May 18, 2023 18:55

build branch

47c7cd0

aws build

c8481b9

getFeedGenerators test

d1fce54

For now only use new replyRef union for custom feeds, for compat

21867d2

devinivy mentioned this pull request May 19, 2023

Db migration to prep for custom feeds #1074

Merged

devinivy added 2 commits May 19, 2023 12:58

Don't use replyRef union on new feeds yet

12431b1

Merge remote-tracking branch 'origin/main' into custom-feeds

d697ba6

devinivy reviewed May 19, 2023

View reviewed changes

devinivy approved these changes May 19, 2023

View reviewed changes

devinivy merged commit 8059e07 into main May 19, 2023
8 checks passed

devinivy deleted the custom-feeds branch May 19, 2023 22:31

devinivy mentioned this pull request Jun 12, 2023

Pds proxy to appview based on headers #1191

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom feeds #1001

Custom feeds #1001

dholms commented May 8, 2023 •

edited by devinivy

roj1512 commented May 8, 2023

aliceisjustplaying May 18, 2023

dholms May 19, 2023

devinivy May 18, 2023 •

edited

dholms May 19, 2023

devinivy May 19, 2023

		.whereNotExists(accountService.mutedQb(requester, [ref('post.creator')]))
		.whereNotExists(graphService.blockQb(requester, [ref('post.creator')]))

Custom feeds #1001

Custom feeds #1001

Conversation

dholms commented May 8, 2023 • edited by devinivy

roj1512 commented May 8, 2023

aliceisjustplaying May 18, 2023

Choose a reason for hiding this comment

dholms May 19, 2023

Choose a reason for hiding this comment

devinivy May 18, 2023 • edited

Choose a reason for hiding this comment

dholms May 19, 2023

Choose a reason for hiding this comment

devinivy May 19, 2023

Choose a reason for hiding this comment

dholms commented May 8, 2023 •

edited by devinivy

devinivy May 18, 2023 •

edited