Fix dev env public url #1058
Merged
Fix dev env public url #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we're now using the same utils for dev-env + test environments, this broke a bunch of tests. I moved the same config over to the setup of the network for the dev-env which should fix this for you & prevent it from breaking tests |
dholms
added a commit
that referenced
this pull request
May 18, 2023
* Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com>
dholms
added a commit
that referenced
this pull request
May 18, 2023
* implement some starter bsky algos * add team dids * tidy * add quotepost check to whats hot classic * tests * carve out feedgen section of pds * apply limits * add describeFeedGenerator route * Whats hot new (#1060) * map out new whats hot * only available in postgres * Fix dev env public url (#1058) * Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com> * add defs for feed gen prefs & decrease displayName length * build branch * updated how saved feeds works * build algos branch * remove relative imports to @atproto/api * update hot classic name * rm build --------- Co-authored-by: Paul Frazee <pfrazee@gmail.com>
devinivy
added a commit
that referenced
this pull request
May 19, 2023
* actor type in profiles * skeleton lex * more schemas * first pass at feed composition * cleanup services * more tidying * fix up tests * bookmarking schemas * make feeds records instead of actors * some cleanup * fleshing out feeds as records * wip * working into cfg & dev-env * fix appview test util * bookmarking + views * tidy * add displayName * db migration * wip test * blob processing * first test working! * Sync-up snapshots * wip * Fix pds ctx type * Sync lexicons on pds and api * wip * fully refactor * Prep for open union in reply data in bsky appview, sync-up snapshots * msgs & ports * Make pds did cache sqlite-friendly * Start scaffolding more feedgen tests * revamp appview tests * revamp pds tests * merge in dev env utils * ensure plc close * add feed gen to dev-env * second feed gen * named feeds in mock * fix issue with dev-env pds appview * update bsky snaps * Flesh-out some feed gen tests * Fix feed gen reply test * Test feed bookmarking * update skeleton defs * merge * Sync-up pds with updated feed skeleton contract * Fix feed bookmark viewer state * add feed embeds * Test inaccurate feed gen repost * Tighten some error behaviors around feed gens * generator view in record embed * test * bookmarked/subscribed -> saved * updated snaps * name & descript on alices feed * add like counts * proposed lex * tweak * fetch feed generator details * add describeFeedGen to dev-env * adds tests for getFeedGenerator * Update lexicons/app/bsky/feed/getFeedGenerator.json Co-authored-by: devin ivy <devinivy@gmail.com> * update describe * add cid to feed gen view * add alice feed gen avatar * generator displayName required * update snaps * Fix dev env public url (#1058) * Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com> * add defs for feed gen prefs & decrease displayName length * build branch * updated how saved feeds works * cleanup lex * mount route * Starter bsky algos (#1046) * implement some starter bsky algos * add team dids * tidy * add quotepost check to whats hot classic * tests * carve out feedgen section of pds * apply limits * add describeFeedGenerator route * Whats hot new (#1060) * map out new whats hot * only available in postgres * Fix dev env public url (#1058) * Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com> * add defs for feed gen prefs & decrease displayName length * build branch * updated how saved feeds works * build algos branch * remove relative imports to @atproto/api * update hot classic name * rm build --------- Co-authored-by: Paul Frazee <pfrazee@gmail.com> * v0.3.6 * v0.3.7 * v0.1.10 * update name of skyline * build branch * aws build * getFeedGenerators test * For now only use new replyRef union for custom feeds, for compat * Don't use replyRef union on new feeds yet --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: Paul Frazee <pfrazee@gmail.com>
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Sep 26, 2023
* actor type in profiles * skeleton lex * more schemas * first pass at feed composition * cleanup services * more tidying * fix up tests * bookmarking schemas * make feeds records instead of actors * some cleanup * fleshing out feeds as records * wip * working into cfg & dev-env * fix appview test util * bookmarking + views * tidy * add displayName * db migration * wip test * blob processing * first test working! * Sync-up snapshots * wip * Fix pds ctx type * Sync lexicons on pds and api * wip * fully refactor * Prep for open union in reply data in bsky appview, sync-up snapshots * msgs & ports * Make pds did cache sqlite-friendly * Start scaffolding more feedgen tests * revamp appview tests * revamp pds tests * merge in dev env utils * ensure plc close * add feed gen to dev-env * second feed gen * named feeds in mock * fix issue with dev-env pds appview * update bsky snaps * Flesh-out some feed gen tests * Fix feed gen reply test * Test feed bookmarking * update skeleton defs * merge * Sync-up pds with updated feed skeleton contract * Fix feed bookmark viewer state * add feed embeds * Test inaccurate feed gen repost * Tighten some error behaviors around feed gens * generator view in record embed * test * bookmarked/subscribed -> saved * updated snaps * name & descript on alices feed * add like counts * proposed lex * tweak * fetch feed generator details * add describeFeedGen to dev-env * adds tests for getFeedGenerator * Update lexicons/app/bsky/feed/getFeedGenerator.json Co-authored-by: devin ivy <devinivy@gmail.com> * update describe * add cid to feed gen view * add alice feed gen avatar * generator displayName required * update snaps * Fix dev env public url (bluesky-social#1058) * Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com> * add defs for feed gen prefs & decrease displayName length * build branch * updated how saved feeds works * cleanup lex * mount route * Starter bsky algos (bluesky-social#1046) * implement some starter bsky algos * add team dids * tidy * add quotepost check to whats hot classic * tests * carve out feedgen section of pds * apply limits * add describeFeedGenerator route * Whats hot new (bluesky-social#1060) * map out new whats hot * only available in postgres * Fix dev env public url (bluesky-social#1058) * Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com> * add defs for feed gen prefs & decrease displayName length * build branch * updated how saved feeds works * build algos branch * remove relative imports to @atproto/api * update hot classic name * rm build --------- Co-authored-by: Paul Frazee <pfrazee@gmail.com> * v0.3.6 * v0.3.7 * v0.1.10 * update name of skyline * build branch * aws build * getFeedGenerators test * For now only use new replyRef union for custom feeds, for compat * Don't use replyRef union on new feeds yet --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: Paul Frazee <pfrazee@gmail.com>
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* actor type in profiles * skeleton lex * more schemas * first pass at feed composition * cleanup services * more tidying * fix up tests * bookmarking schemas * make feeds records instead of actors * some cleanup * fleshing out feeds as records * wip * working into cfg & dev-env * fix appview test util * bookmarking + views * tidy * add displayName * db migration * wip test * blob processing * first test working! * Sync-up snapshots * wip * Fix pds ctx type * Sync lexicons on pds and api * wip * fully refactor * Prep for open union in reply data in bsky appview, sync-up snapshots * msgs & ports * Make pds did cache sqlite-friendly * Start scaffolding more feedgen tests * revamp appview tests * revamp pds tests * merge in dev env utils * ensure plc close * add feed gen to dev-env * second feed gen * named feeds in mock * fix issue with dev-env pds appview * update bsky snaps * Flesh-out some feed gen tests * Fix feed gen reply test * Test feed bookmarking * update skeleton defs * merge * Sync-up pds with updated feed skeleton contract * Fix feed bookmark viewer state * add feed embeds * Test inaccurate feed gen repost * Tighten some error behaviors around feed gens * generator view in record embed * test * bookmarked/subscribed -> saved * updated snaps * name & descript on alices feed * add like counts * proposed lex * tweak * fetch feed generator details * add describeFeedGen to dev-env * adds tests for getFeedGenerator * Update lexicons/app/bsky/feed/getFeedGenerator.json Co-authored-by: devin ivy <devinivy@gmail.com> * update describe * add cid to feed gen view * add alice feed gen avatar * generator displayName required * update snaps * Fix dev env public url (bluesky-social#1058) * Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com> * add defs for feed gen prefs & decrease displayName length * build branch * updated how saved feeds works * cleanup lex * mount route * Starter bsky algos (bluesky-social#1046) * implement some starter bsky algos * add team dids * tidy * add quotepost check to whats hot classic * tests * carve out feedgen section of pds * apply limits * add describeFeedGenerator route * Whats hot new (bluesky-social#1060) * map out new whats hot * only available in postgres * Fix dev env public url (bluesky-social#1058) * Fix the public url used by dev-env * move publicUrl location --------- Co-authored-by: dholms <dtholmgren@gmail.com> * add defs for feed gen prefs & decrease displayName length * build branch * updated how saved feeds works * build algos branch * remove relative imports to @atproto/api * update hot classic name * rm build --------- Co-authored-by: Paul Frazee <pfrazee@gmail.com> * v0.3.6 * v0.3.7 * v0.1.10 * update name of skyline * build branch * aws build * getFeedGenerators test * For now only use new replyRef union for custom feeds, for compat * Don't use replyRef union on new feeds yet --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: Paul Frazee <pfrazee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this URL to be correct for images in the dev env