Lexicon: Replace all user parameters with actor or repo #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
commented
Mar 13, 2023
| "parameters": { | ||
| "type": "params", | ||
| "required": ["author"], | ||
| "required": ["actor"], |
There was a problem hiding this comment.
I took a bit of liberty here & changed it to actor even tho it wasn't ambiguous like user. Let me know if you disagree
|
Ooh, found one little thing I wonder if we oughtta tidy-up while we're in here. There's a field called |
|
I just pushed up that change I mentioned above— we can always revert if we'd rather not include it 👍 |
|
Nope I like it! & now that we have formats, it's totally clear what the value is supposed to be by looking at the schema 👍 |
This was referenced Mar 14, 2023
Merged
dholms
force-pushed
the
lex/xprc-user-params
branch
from
7832eb2
to
4c3a1ee
Compare
devinivy
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove vague "user" references.
If in the
com.atprotonamespace, we use "repo"If in the
app.bsky, we use "actor"Closes #591
Closes #548