Lexicon: remove actor declaration and assertion/confirmations #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
force-pushed
the
lex/xprc-user-params
branch
from
7832eb2
to
4c3a1ee
Compare
dholms
reviewed
Mar 14, 2023
| @@ -10,7 +10,7 @@ | |||
| "type": "object", | |||
| "required": ["subject", "createdAt"], | |||
| "properties": { | |||
| "subject": {"type": "ref", "ref": "app.bsky.actor.ref"}, | |||
| "subject": {"type": "string", "format": "did"}, | |||
Merged
dholms
approved these changes
Mar 14, 2023
…emove-declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes declarations (incl. actor type and declaration cids), assertions, and confirmations. Follow subject is updated to be a plain did rather than a did/declaration pair.
The app-view indexes are cleared of all these records, but there will be an additional PR (incoming) to migrate them out of repos as well.
One unrelated change in here is that I removed pds/tests/migrations/duplicate-records.ts since it was out of date, doesn't run as part of the test suite, and would have required some non-trivial changes to bring up to date.
Note that this is waterfalling into #655, we should let that land first. Resolves #579, resolves #586.