Lexicon: richtext facets, replacing post entities #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
commented
Mar 16, 2023
| @@ -12,8 +12,13 @@ | |||
| "text": {"type": "string", "maxLength": 256}, | |||
| "entities": { | |||
| "type": "array", | |||
| "description": "Deprecated: replaced by app.bsky.richtext.facet.", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Deprecated: replaced by app.bsky.richtext.facet.", | |
| "description": "Deprecated: replaced by facets.", |
devinivy
commented
Mar 16, 2023
| "description": "A facet value for links.", | ||
| "required": ["uri"], | ||
| "properties": { | ||
| "uri": {"type": "string"} |
There was a problem hiding this comment.
Minor note: in #587 I think the intention was to use a uri format here, but we decided to just have the at-uri format for now, which wouldn't apply here.
There was a problem hiding this comment.
actually I'd be down to throw in a uri format 🤷♂️
Merged
dholms
reviewed
Mar 17, 2023
| import { Kysely } from 'kysely' | ||
|
|
||
| export async function up(db: Kysely<unknown>): Promise<void> { | ||
| await db.schema.alterTable('post_entity').renameTo('post_facet').execute() |
There was a problem hiding this comment.
I remember this table is missing a primary key. Would be a good time to get one on it
But also: I don't think we actually use this table for anything. Maybe we could drop??
There was a problem hiding this comment.
Yeah good call, let's just drop this bad boy.
dholms
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the post entities system and introduces richtext facets through
app.bsky.richtext.facet.Resolves #587