Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app.bsky.richtext.facet #587

Closed
pfrazee opened this issue Feb 22, 2023 · 1 comment
Closed

Add app.bsky.richtext.facet #587

pfrazee opened this issue Feb 22, 2023 · 1 comment
Assignees

Comments

@pfrazee
Copy link
Collaborator

pfrazee commented Feb 22, 2023

  • Add app.bsky.richtext.facet
    • Has an index which is #textSlice
    • and value which is an open union of #link and #mention
    • #link has a uri field
    • #mention has a did field
  • Update app.bsky.feed.post...
    • Mark entities as deprecated but leave it in
    • Add facets as an optional field
    • This will make migration smooth — we keep supporting entities but start writing and using facets
  • Update notification indexing to read the facets field but keep around the old entities field with a plan to deprecate
  • Reasoning
    • Entities was created before Lexicon was fleshed out and it needs to use specific types, especially because it has indexing implications
    • Different kinds of facets have different field needs
    • As we expand on content-types, we’ll need a more robust rich text system, which entities basically was
    • The term “entities” confused people
@dholms
Copy link
Collaborator

dholms commented Apr 4, 2023

fixed #658

@dholms dholms closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants