Show labeler info in labels and adjust color coding #61

foysalit · 2024-03-18T23:39:37Z

This PR fetches labeler service details and shows info about the service and the label along with any label on contents to make it easier for moderators to skim through labels.

NOTE: As a side effect of behavior based color coding, this PR removes hard coded color coding based on label categories. This is based on the fact that 3rd parties running the service won't benefit from any of the color coding and our own moderators don't seem to rely on the color coding much.

Self Label

Labeler service details

…minent

render · 2024-03-18T23:39:41Z

Your Render PR Server URL is https://ozone-staging-pr-61.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cnsd1eo21fec73aadh40.

render · 2024-03-18T23:39:43Z

Your Render PR Server URL is https://ozone-sandbox-pr-61.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cnsd1fg21fec73aadh90.

devinivy · 2024-03-20T18:14:00Z

app/actions/ModActionPanel/QuickAction.tsx

+                      Last{' '}
+                      {subjectStatus.reviewState ===
+                      ToolsOzoneModerationDefs.REVIEWNONE
+                        ? 'event'
+                        : 'reviewed'}{' '}
+                      at:{' '}
                      {dateFormatter.format(
                        new Date(subjectStatus.lastReviewedAt),


Is lastReviewedAt set when the review state is REVIEWNONE?

devinivy · 2024-03-20T18:14:21Z

app/actions/ModActionPanel/QuickAction.tsx

-                  {currentLabels.map((label) => {
-                    const labelGroup = getLabelGroupInfo(unFlagSelfLabel(label))
+                  {allLabels.map((label) => {
+                    // const labelGroup = getLabelGroupInfo(unFlagSelfLabel(label))


Suggested change

// const labelGroup = getLabelGroupInfo(unFlagSelfLabel(label))

Thought I saw this get cleaned-up too, but it's still here. Maybe some changes ended-up getting clobbered?

devinivy · 2024-03-20T18:16:38Z

components/common/labels/List.tsx

+          <h4 className="leading-4">
+            <b>{label.val}</b> label does not have a custom definition. Users
+            will be able to configure the behavior of the label in app.
+          </h4>


I'm not 100% sure whether this is accurate—we might want to check in with Paul/Bryan about the right way of messaging around this case.

it's not. some labels are configurable in app though so changed the text from `will be" to "may be" which should have us covered.

devinivy · 2024-03-20T18:20:14Z

components/common/labels/useLabelerDefinition.ts

+      if (labelerDef?.policies.labelValueDefinitions) {
+        const definitionsById: Record<
+          string,
+          ComAtprotoLabelDefs.LabelValueDefinition
+        > = {}
+        labelerDef.policies.labelValueDefinitions.forEach((def) => {
+          definitionsById[def.identifier] = def
+        })
+        labelerDef.policies.definitionById = definitionsById
+      }


Is there something in particular that we find in here that we aren't able to get from session.config.labeler?

so, the idea of this PR is that eventually, we could plug in other labelers into ozone. Bryan touched on this I think somewhere that other labelers may want to see labels added by bluesky.

there's a bit more work left to get this all to work and get the backend to send labels from other labelers but once that's done, this will make more sense I think.

devinivy · 2024-03-20T18:20:51Z

components/common/posts/PostsFeed.tsx

+          <ModerationLabel
+            recordAuthorDid={item.post.author.did}
+            label={label}


I wonder if this needs a key.

there is a key, the last prop.

devinivy · 2024-03-20T18:22:53Z

lib/constants.ts

+export const OZONE_SERVICE_DID =
+  process.env.NEXT_PUBLIC_OZONE_SERVICE_DID ||
+  'did:plc:ar7c4by46qjdydhdevvrndac'


I am not sure that we need to hardcode our labeler in Ozone. The service DID may also be set at runtime by fetching ozone-metadata.json, as is the case when running the dockerized Ozone distribution.

ooops... accidental commit, will clean up

@foysalit I thought I saw this get cleaned-up, but it still is kicking around here.

yh idk what's up but I think I lost some changes when merging main into this.

devinivy · 2024-03-20T18:23:59Z

lib/client.ts

+    const builtIn = ozoneDid || OZONE_SERVICE_DID
    return await getConfig(builtIn)


For the Ozone distribution we need to leave the possibility open that builtIn is not set, and may be determined at runtime within getConfig.

yep, cleaning up the fallback of service did to our labeler should be enough for that, no?

devinivy

The functionality here is awesome! Just a couple questions for us to answer around runtime configuration and a bit of copy in the app.

bnewbold

this is really great! nice polish

devinivy · 2024-04-08T15:23:01Z

components/mod-event/EventItem.tsx

+        // Moderation events being displayed means that these events were added by the current service
+        // so we can assume that the src is the same as the configured ozone service DID
        return (
-          <LabelChip key={label} style={{ color: labelGroup.color }}>
-            {displayLabel(label)}
-          </LabelChip>
+          <ModerationLabel
+            key={label}
+            label={{ val: label, src: OZONE_SERVICE_DID, uri: '', cts: '' }}
+          />


I don't think we'll be able to capture the "current service" using a constant, since it may be determined at runtime. I think there's a useSession() hook kicking around that we could use to grab it, though.

we can also just get it from client directly, right?

…r-subject-support

devinivy

Looks good!

foysalit added 5 commits March 14, 2024 21:09

💄 Handle reviewNone, labeler account display and sticky note more pro…

1447bcf

…minent

🐛 Change icon for reviewNone

0d7c3fd

💄 Handle user badge in dark mode

7f412f5

💄 Show labels with mod service details

5517cd0

💄 Color code labels based on blur and hide config

8381dd0

foysalit requested review from devinivy and bnewbold March 18, 2024 23:41

💄 Add ModerationLabel in record and repo view

bafe609

devinivy reviewed Mar 20, 2024

View reviewed changes

🔀 Merge with upstream

c0ff46c

bnewbold approved these changes Apr 4, 2024

View reviewed changes

devinivy reviewed Apr 8, 2024

View reviewed changes

foysalit added 4 commits April 12, 2024 14:20

Merge branch 'main' of github.com:bluesky-social/ozone-ui into labele…

f6e9271

…r-subject-support

✨ Cleanup

60754fe

🔀 Merge with upstream

9ba3ba5

🧹 Cleanup

995e94b

devinivy approved these changes Apr 17, 2024

View reviewed changes

foysalit merged commit 4d66e7b into main Apr 17, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show labeler info in labels and adjust color coding #61

Show labeler info in labels and adjust color coding #61

foysalit commented Mar 18, 2024 •

edited

Loading

render bot commented Mar 18, 2024

render bot commented Mar 18, 2024

devinivy Mar 20, 2024

foysalit Apr 17, 2024

devinivy Mar 20, 2024

devinivy Apr 8, 2024

devinivy Mar 20, 2024

foysalit Apr 17, 2024

devinivy Mar 20, 2024

foysalit Mar 23, 2024

devinivy Mar 20, 2024

foysalit Apr 12, 2024

devinivy Mar 20, 2024

foysalit Mar 23, 2024

devinivy Apr 8, 2024 •

edited

Loading

foysalit Apr 12, 2024

devinivy Mar 20, 2024

foysalit Apr 12, 2024

devinivy left a comment

bnewbold left a comment

devinivy Apr 8, 2024 •

edited

Loading

foysalit Apr 12, 2024

devinivy left a comment

		const builtIn = ozoneDid \|\| OZONE_SERVICE_DID
		return await getConfig(builtIn)

Show labeler info in labels and adjust color coding #61

Show labeler info in labels and adjust color coding #61

Conversation

foysalit commented Mar 18, 2024 • edited Loading

render bot commented Mar 18, 2024

render bot commented Mar 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devinivy Apr 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devinivy left a comment

Choose a reason for hiding this comment

bnewbold left a comment

Choose a reason for hiding this comment

devinivy Apr 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devinivy left a comment

Choose a reason for hiding this comment

foysalit commented Mar 18, 2024 •

edited

Loading

devinivy Apr 8, 2024 •

edited

Loading

devinivy Apr 8, 2024 •

edited

Loading