Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French localization #4611

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Conversation

surfdude29
Copy link
Contributor

Following on from my previous PRs, I again used DeepL and my own knowledge of French to translate the new strings.

All feedback from native French speakers is welcome – especially @Signez of course 🙏

Most of the new strings are related to the upcoming starter packs feature, and I went with pack de démarrage but I have no strong attachment to that so if there's a better translation please let me know :)

I didn't really have a clue what word would be best to use for toggle as a noun here:

name={type === 'user' ? _(msg`Person toggle`) : _(msg`Feed toggle`)}

so I took a guess with bouton but that's almost certainly wrong. Please let me know what it should actually be 😄

@Signez
Copy link
Contributor

Signez commented Jun 24, 2024

Hey! I'm just starting now to review your changes, can't wait to dive into those translations.

But first, about starter pack, honestly pack de démarrage is okay, but I feel that kit de démarrage would be even better. If you are okay with such a change, you can find & replace it across all your translations: those nominal groups have the same gender (masculine).

For toggle, I think that most of the time bascule works well, but to be fair, Bascule d‘utilisateur doesn't mean much and sounds weird even in context… honestly, bouton d’ajout ou de retrait de l’utilisateur is nearly the choice that would sound the less weird, but I wasn't really sure if it would fit in the UI (or is it an accessibility label? not clear when I browse the code 😬)

@surfdude29
Copy link
Contributor Author

But first, about starter pack, honestly pack de démarrage is okay, but I feel that kit de démarrage would be even better. If you are okay with such a change, you can find & replace it across all your translations: those nominal groups have the same gender (masculine).

Great, just done that 👍

For toggle, I think that most of the time bascule works well, but to be fair, Bascule d‘utilisateur doesn't mean much and sounds weird even in context… honestly, bouton d’ajout ou de retrait de l’utilisateur is nearly the choice that would sound the less weird, but I wasn't really sure if it would fit in the UI (or is it an accessibility label? not clear when I browse the code 😬)

I think it has to be an accessibility label because it doesn't seem like it's displayed in the interface, but then it looks to me like there's an accessibility label right after that? So I'm really not sure what's going on there 🤷🏻‍♂️

Please suggest whatever you think is best and I'll go with it :)

Copy link
Contributor

@Signez Signez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translations, again! We have to deal with some langage inclusive matters this time though :)

(and a very nasty, hidden error on date formatting… quite happy to have caught it early!)

src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved

#: src/screens/StarterPack/Wizard/index.tsx:497
msgid "<0>{0}, </0><1>{1}, </1>and {2} {3, plural, one {other} other {others}} are included in your starter pack"
msgstr ""
msgctxt "profiles"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG THEY THOUGHT OF US, POOR LOCALIZERS, THANKS TO THE BLUESKY TEAM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @/tkusano in #4607 💫

src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
@Signez
Copy link
Contributor

Signez commented Jun 24, 2024

Great, just done that 👍

Cool! Please make sure to read the comments on the "outdated" strings, as they may be still be relevant (those comments are marked as outdated because of the find & replace).

surfdude29 and others added 2 commits June 24, 2024 22:01
Co-authored-by: Stanislas Signoud <signez@stanisoft.net>
@surfdude29
Copy link
Contributor Author

OK I think I got all the changes (sorry for doing the find and replace while you were doing your review, I should have waited until you had finished to avoid complicating things).

I just wanted to double-check whether it should be dans or de here:
#4611 (comment)

@surfdude29 surfdude29 marked this pull request as ready for review June 24, 2024 23:32
@pfrazee
Copy link
Collaborator

pfrazee commented Jun 25, 2024

Okay, we're set?

@surfdude29
Copy link
Contributor Author

Yup, ready to go @pfrazee

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks all!!

@pfrazee pfrazee merged commit 615c0c8 into bluesky-social:main Jun 25, 2024
6 checks passed
@surfdude29 surfdude29 deleted the update-french branch June 25, 2024 00:54
This was referenced Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants