-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update French localization #4611
Conversation
Hey! I'm just starting now to review your changes, can't wait to dive into those translations. But first, about For |
Great, just done that 👍
I think it has to be an accessibility label because it doesn't seem like it's displayed in the interface, but then it looks to me like there's an accessibility label right after that? So I'm really not sure what's going on there 🤷🏻♂️ Please suggest whatever you think is best and I'll go with it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great translations, again! We have to deal with some langage inclusive matters this time though :)
(and a very nasty, hidden error on date formatting… quite happy to have caught it early!)
|
||
#: src/screens/StarterPack/Wizard/index.tsx:497 | ||
msgid "<0>{0}, </0><1>{1}, </1>and {2} {3, plural, one {other} other {others}} are included in your starter pack" | ||
msgstr "" | ||
msgctxt "profiles" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG THEY THOUGHT OF US, POOR LOCALIZERS, THANKS TO THE BLUESKY TEAM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @/tkusano in #4607 💫
Cool! Please make sure to read the comments on the "outdated" strings, as they may be still be relevant (those comments are marked as outdated because of the find & replace). |
Co-authored-by: Stanislas Signoud <signez@stanisoft.net>
OK I think I got all the changes (sorry for doing the find and replace while you were doing your review, I should have waited until you had finished to avoid complicating things). I just wanted to double-check whether it should be |
Okay, we're set? |
Yup, ready to go @pfrazee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks all!!
Following on from my previous PRs, I again used DeepL and my own knowledge of French to translate the new strings.
All feedback from native French speakers is welcome – especially @Signez of course 🙏
Most of the new strings are related to the upcoming starter packs feature, and I went with
pack de démarrage
but I have no strong attachment to that so if there's a better translation please let me know :)I didn't really have a clue what word would be best to use for
toggle
as a noun here:social-app/src/components/StarterPack/Wizard/WizardListCard.tsx
Line 52 in 0a0c738
so I took a guess with
bouton
but that's almost certainly wrong. Please let me know what it should actually be 😄