Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French localization #4662

Merged
merged 11 commits into from
Jul 5, 2024

Conversation

surfdude29
Copy link
Contributor

As a follow-up to #4611 and #4637 this PR adds translations for new strings, especially some high-visibility starter pack-related ones. It also includes one correction where I had missed changing Packs to Kits.

I'd be grateful if you could take a look @Signez 🙏

Copy link
Contributor

@Signez Signez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, as always! 🚀

src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
@surfdude29
Copy link
Contributor Author

Thanks again @Signez, suggestion applied 🙏

@surfdude29 surfdude29 marked this pull request as ready for review June 27, 2024 08:12
@surfdude29
Copy link
Contributor Author

I've added translations for the new strings that have been added recently, including the onboarding tour, the progress guide etc.

I'd be grateful if you could look them over please @Signez 🙏

Copy link
Contributor

@Signez Signez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! A few ideas/nitpicks as always, but still, good work 👍

src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
Co-authored-by: Stanislas Signoud <signez@stanisoft.net>
@surfdude29
Copy link
Contributor Author

All suggestions applied, once again many thanks @Signez for your quick and helpful feedback! :)

This is now up-to-date and ready to go @pfrazee 🫡

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good deal! Thanks all!

@pfrazee pfrazee merged commit d5fd19d into bluesky-social:main Jul 5, 2024
6 checks passed
@surfdude29 surfdude29 deleted the update-french-localization branch July 5, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants