Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newskie dialog tweaks #4623

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Newskie dialog tweaks #4623

merged 1 commit into from
Jun 24, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Jun 24, 2024 •
edited
Loading

Tweaks:

  • line height of multiline text
  • icon spacing around title
  • used modal close X on web

Before/after
CleanShot 2024-06-24 at 17 22 38@2x
CleanShot 2024-06-24 at 17 25 26@2x

CleanShot 2024-06-24 at 17 30 03@2x
CleanShot 2024-06-24 at 17 29 32@2x

@render Render
Copy link

render bot commented Jun 24, 2024

Your Render PR Server URL is https://social-app-pr-4623.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cpsv5suehbks73av11vg.

@estrattonbailey estrattonbailey marked this pull request as ready for review June 24, 2024 22:31
@github-actions GitHub Actions
Copy link

Old size New size Diff
6.47 MB 6.47 MB -45 B (-0.00%)

pfrazee
pfrazee approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice lg

@pfrazee pfrazee merged commit ffb6739 into main Jun 24, 2024
6 checks passed
@pfrazee pfrazee deleted the newskie-tweaks branch June 24, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfrazee pfrazee pfrazee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@estrattonbailey @pfrazee