Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add a column on adaptive scales #18

Merged
merged 3 commits into from Sep 10, 2020

Conversation

tacaswell
Copy link
Contributor

No description provided.

Copy link
Member

@danielballan danielballan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. Minor suggestion left for consideration. Merge at will.

index.html Outdated
<li> data quality checks </li>
<li> prompt / real-time analysis to steer experiment
<ul>
<li> "human-in-the-loop" </li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think human vs computer applies to both data quality checks and experiment steering. Maybe make a separate bulleted list rather than sub-bullets on this point.

index.html Outdated
<li> very limited time budget for analysis </li>
<li> very limited access to data </li>
<li> tightly coupled to hardware (PID loop, FGPA) </li>
<li> expensive to write </li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I initially misread "write" in the sense of writing data, being primed into that context by the points above. On a moment's thought it's clear, but maybe a word like "build" or "make" would by unambiguous.

@danielballan
Copy link
Member

CI failure is unrelated.

@danielballan danielballan merged commit ffab610 into bluesky:master Sep 10, 2020
@tacaswell tacaswell deleted the WIP_adaptive_column branch September 10, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants