Future support #1512
Future support #1512
Conversation
|
we can pip install pyqt6, do you think it is worth an extra CI job? Testing both in one process is between a very bad idea (because it might crash) and impossible (because it will crash). |
|
I think we can have an extra job in CI for that case (for Python 3.7 only probably as https://pypi.org/project/PyQt6/6.3.0/#files has the wheels only for that version). Do we want to maintain a separate |
The current development branch of databroker does no have `temp` anymore.
Continues to rely on Matplotlib's compat layer
Use strings not floats
Only happens on py310. Databroker is moving away from intake so just skip.
|
I added pyqt6 to py310 and if pyqt6 is installed mpl 3.5 and up will pick it automatically. |
There was a problem hiding this comment.
Looks good to me, thanks for the detailed docstring. I had a non-blocking and a more general question about abi3, but googling it helped me understand it (e.g. in https://pyo3.rs/v0.13.2/building_and_distribution.html#py_limited_apiabi3).
|
@klauer, are you OK with this update? Let's have it in if there are no objections. |
|
Nothing on my end 👍 |
|
Thanks, Ken! I'll go ahead and will merge it then. Thanks for the future support fix, @tacaswell! |
This is the start of work to support future versions of Python + QT + databroker