Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin jsonschema in requirements? #193

Closed
dylanmcreynolds opened this issue Oct 8, 2020 · 3 comments · Fixed by #201
Closed

Unpin jsonschema in requirements? #193

dylanmcreynolds opened this issue Oct 8, 2020 · 3 comments · Fixed by #201

Comments

@dylanmcreynolds
Copy link
Contributor

The travis configuration effectively pins it to jsonschema 2.x because of an issue with PIP sometimes pulling down 2 instead of 3.

I raised this an issue in slack, and @tacaswell said "we should probably un-pin the jsonschema version".

@danielballan
Copy link
Member

I thought he was suggesting un-pinning it in our requirements. I think we need to keep pinning it in Travis to ensure that it keeps working on 2 and 3.

@dylanmcreynolds
Copy link
Contributor Author

that's a little confusing, in requirements.txt:

jsonschema>=3.0.0

@danielballan
Copy link
Member

Right. Since pip sometimes does not respect pins (long story) we sometimes get 2.x in spite of that pin. For this reason, we restored compact with both 2 and 3 and continue to test on both. Given that, there is no reason to continue to pin in the requirements file.

@danielballan danielballan changed the title Unpin jsonschema 2.x in travis? Unpin jsonschema in requirements? Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants