Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClobberError conflict with typhos #22

Closed
prjemian opened this issue Aug 13, 2020 · 5 comments · Fixed by #32
Closed

ClobberError conflict with typhos #22

prjemian opened this issue Aug 13, 2020 · 5 comments · Fixed by #32
Assignees
Labels
Milestone

Comments

@prjemian
Copy link
Contributor

prjemian commented Aug 13, 2020

When installing hklpy and typhos as part of a bluesky environment for the APS, two ClobberError reports were generated (BCDA-APS/use_bluesky#63) during the environment creation process (on linux x86_64, linux mint).

ClobberError: This transaction has incompatible packages due to a shared path.
  packages: nsls2forge/noarch::hklpy-0.3.14-py_0, conda-forge/noarch::typhos-1.0.2-py_0
  path: 'lib/python3.8/site-packages/tests/__init__.py'


ClobberError: This transaction has incompatible packages due to a shared path.
  packages: nsls2forge/noarch::hklpy-0.3.14-py_0, conda-forge/noarch::typhos-1.0.2-py_0
  path: 'lib/python3.8/site-packages/tests/__pycache__/__init__.cpython-38.pyc'
@prjemian prjemian added the bug label Aug 13, 2020
@prjemian prjemian self-assigned this Aug 13, 2020
@prjemian
Copy link
Contributor Author

prjemian commented Aug 13, 2020

Does this package install into tests? Why? Same question asked of typhos: pcdshub/typhos#397

@prjemian
Copy link
Contributor Author

In the fix for Typhos, the tests directory was moved to the typhos/tests directory. Same here?

@klauer
Copy link
Member

klauer commented Aug 13, 2020

That'd work - if others are OK with it.

May want to preemptively look for other repositories that have a top-level /tests/ directory

@prjemian prjemian added this to the 0.3.15 milestone Sep 2, 2020
prjemian added a commit that referenced this issue Sep 26, 2020
prjemian added a commit that referenced this issue Sep 26, 2020
@prjemian
Copy link
Contributor Author

flake8 test (per similar actions in typhos):

(hkl) prjemian@poof ~/.../projects/hklpy $ flake8 hkl/tests/test_tardis.py 
hkl/tests/test_tardis.py:6:1: F401 'ophyd' imported but unused
hkl/tests/test_tardis.py:12:1: E402 module level import not at top of file
hkl/tests/test_tardis.py:13:1: E402 module level import not at top of file
hkl/tests/test_tardis.py:14:1: E402 module level import not at top of file
hkl/tests/test_tardis.py:25:5: E741 ambiguous variable name 'l'
hkl/tests/test_tardis.py:69:80: E501 line too long (92 > 79 characters)
hkl/tests/test_tardis.py:91:80: E501 line too long (82 > 79 characters)
hkl/tests/test_tardis.py:133:1: E302 expected 2 blank lines, found 1
hkl/tests/test_tardis.py:157:1: E302 expected 2 blank lines, found 1
hkl/tests/test_tardis.py:184:54: E262 inline comment should start with '# '
hkl/tests/test_tardis.py:188:54: E262 inline comment should start with '# '
hkl/tests/test_tardis.py:192:5: E303 too many blank lines (2)

@prjemian
Copy link
Contributor Author

  • E402 must come before import hkl so must tolerate
  • E741 is for science variable l so must tolerate

now:

(hkl) prjemian@poof ~/.../projects/hklpy $ flake8 hkl/tests/test_tardis.py 
hkl/tests/test_tardis.py:11:1: E402 module level import not at top of file
hkl/tests/test_tardis.py:12:1: E402 module level import not at top of file
hkl/tests/test_tardis.py:13:1: E402 module level import not at top of file
hkl/tests/test_tardis.py:24:5: E741 ambiguous variable name 'l'

prjemian added a commit that referenced this issue Sep 26, 2020
prjemian added a commit that referenced this issue Sep 26, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants