Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

Make tests run faster by doing intake_server fixture per module not per function #51

Closed
danielballan opened this issue Jun 7, 2019 · 1 comment

Comments

@danielballan
Copy link
Member

The tests run slowly right now because each tests stand up a fresh intake_server fixture, which involves starting up a Tornado server. A separate server per test has advantages---it ensures that tests don't mutually interfere via persisted state on the server---and it probably makes sense for intake tests to take that approach.

But if we can assume that the intake server itself it working, I think it is safe to set up one server per module rather than one server per test. My guess is that this would reduce the test time by ~100X and make development much nicer.

@danielballan
Copy link
Member Author

Closed by #60

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant