Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the move! #228

Closed
gilesknap opened this issue Apr 17, 2024 · 1 comment
Closed

Remove the move! #228

gilesknap opened this issue Apr 17, 2024 · 1 comment

Comments

@gilesknap
Copy link
Contributor

gilesknap commented Apr 17, 2024 •
edited

The opyhd_async.epics.morot.Motor.move() function does a synchronous move.

@coretl asserts that this is a bad thing as it requires an active RunEngine event loop.

Instead use:

await my_motor.set(position)
@coretl coretl mentioned this issue Apr 24, 2024
Merged
dperl-dls added a commit that referenced this issue May 1, 2024
@dperl-dls
(#228) remove synchronous move method
d5eff2b
@coretl
Copy link
Collaborator

coretl commented Jun 24, 2024

Done in #117

@coretl coretl closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gilesknap @coretl