Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enum on aravis driver #412

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Use enum on aravis driver #412

merged 2 commits into from
Jun 26, 2024

Conversation

callumforrester
Copy link
Contributor

Fixes #411

@callumforrester callumforrester force-pushed the 411-fix-aravis-broken branch 2 times, most recently from 3a9f7f0 to 7bb36f1 Compare June 25, 2024 14:05
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
@DiamondJoseph
Copy link
Contributor

Pretty sure we should support LineN for N in {1,2,3,4}.
Docstring should be updated above AravisTriggerSource

@callumforrester
Copy link
Contributor Author

Line1 was the only thing that came back in the error, I presume if we supported LineN, then the connection would break again. Need @coretl's input

@coretl
Copy link
Collaborator

coretl commented Jun 25, 2024

Manta supports Line1 and Line2. Mako supports only Line1. We list the lowest common denominator for type checking, then it's typed as a string at runtime so we can do sig.set(f"Line{n}")

@callumforrester callumforrester merged commit d739f0f into main Jun 26, 2024
18 checks passed
@callumforrester callumforrester deleted the 411-fix-aravis-broken branch June 26, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADAravis detector broken by new enum requirements
3 participants