Adopt isort #1064
Merged
Adopt isort #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run as a plugin to flake8. Upper bound to flake8 while flake8-isort releases a fix
All relative imports of the top level ophyd package in packages that are themselves imported in the top level ophyd pacakge are changed to point to the relevant subpackages. E.g. if ophyd/__init__.py imports quadem, but quadem imports signal from ophyd, and signal is alphabetically after quadem, then it won't be there The fix is to import Signal from .signal instead of from ..
|
Note the changes I had to make in 6e503c9 as a result of |
tacaswell
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt isort for import ordering, run as a plugin to flake8 using flake8-isort. Adopt in a single commit as per black. Put that commit in .git-blame-ignore-revs so it can be ignored