Ignore DeprecationWarning from Pandas via cachey #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This no longer feels like a I'm probably overthinking this. What do others suggest? |
hyperrealist
pushed a commit
to hyperrealist/tiled
that referenced
this pull request
Mar 18, 2024
* Ignore Pandas DeprecationWarning from cachey.nbytes() * Ignore Pandas DeprecationWarning in tests? * Subclass warnings.catch_warnings for backward compatibility * Make catch_warning_msg a utility; use specialized instance forPandas block warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
cachey.nbytes()issue aDeprecationWarningbecause of direct access to the deprecated internals of Pandas.DeprecationWarnings #675 (comment)This PR catches those warnings at the corresponding calls in Tiled's
object_cachemodule. It also shows where this could be limited to just the tests instead.I favor doing this in the code rather than the tests, but it does add some uncertainty for thread safety.