Skip to content
This repository has been archived by the owner on Jul 6, 2019. It is now read-only.

3.3.0.M2 support #141

Merged
merged 3 commits into from
Oct 13, 2018
Merged

3.3.0.M2 support #141

merged 3 commits into from
Oct 13, 2018

Conversation

sagrawal31
Copy link
Contributor

For issue #140

@aadrian
Copy link

aadrian commented Jul 3, 2018

@bluesliverx any news merging this PR?

Thank you.

@puneetbehl
Copy link
Contributor

@sagrawal31 Can you please send the PR to new-repo?
Also, it looks like some of the tests are failing, so it would be great if you can fix those as well.

@bluesliverx bluesliverx merged commit 489762c into bluesliverx:master Oct 13, 2018
@sagrawal31
Copy link
Contributor Author

Hey @sagrawal31 Sorry I totally missed your last comment and today I'm seeing it again. Thanks for merging it. What about failing tests?

@puneetbehl
Copy link
Contributor

It seems like some imports are missing. Please check the Build Log here

@bluesliverx Are you still maintaining this repository? as I recently moved it to grails-plugins for Grails 3 support.

@bluesliverx
Copy link
Owner

bluesliverx commented Oct 13, 2018

@puneetbehl, I was not (I sheepishly admit), mostly because I was stuck on a very old grails very for my app and this plugin progressed past that. I just upgraded my app finally last week, and today I installed this plugin and am starting to dig in to make sure it still works in Grails 3.3.8.

I'm happy to move it to a repo that you can maintain at if you're volunteering. I made some updates today pulling in changes from random people, so you could even just merge from this in your repo if you'd like to use that one. I could also make you a committer here on this repo if you'd like to maintain it in the current spot.

There was another plugin maintainer who did most of the work (@bobby-vandiver), but he seems to have dropped off as well, probably due to similar reasons.

@puneetbehl
Copy link
Contributor

It's good to have you back. And, the reason I moved the plugin to the grails-plugins repository is that anyone from the Grails team can look into PR and publishing stuff if tomorrow you and I are busy.

I don't have any problems deleting the new repo. Just want to avoid confusions with multiple repositories for the same plugin.

@bluesliverx
Copy link
Owner

I don't mind moving to the new location. Thanks for adding me to it. I'll see if I can get some time this weekend to make it clear that this repo is deprecated, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants