Skip to content
This repository has been archived by the owner on Jul 6, 2019. It is now read-only.

Refactor OAuth2AuthenticationSerializer #61

Merged
merged 1 commit into from
Feb 6, 2015

Conversation

beckje01
Copy link
Contributor

@beckje01 beckje01 commented Feb 2, 2015

This is to allow easier override, the major change is byte[] serialize changing to Object serialize I wanted to change my Gorm classes and use Strings instead with JSON. This should be transparent to most users only someone extending OAuth2AuthenticationSerializer should be effected.

@bobby-vandiver
Copy link
Collaborator

The interface for OAuth2Authentication deserialize(byte[] authentication) should also be changed to reflect the type change since the serialized OAuth2Authentication instance will be passed to deserialize at some point. See OAuth2Authentication readAuthentication(String token) in GormTokenService for an example.

@beckje01
Copy link
Contributor Author

beckje01 commented Feb 4, 2015

Thanks, let me know if you would rather have this rebased and squashed.

@bobby-vandiver
Copy link
Collaborator

I would at least fix up your last two commits to avoid any confusion when checking out the history in the future. It looks like they're the same change anyway. Other than that, it looks good. 👍

@beckje01
Copy link
Contributor Author

beckje01 commented Feb 6, 2015

All squashed.

bobby-vandiver added a commit that referenced this pull request Feb 6, 2015
Refactor OAuth2AuthenticationSerializer
@bobby-vandiver bobby-vandiver merged commit d5fec66 into bluesliverx:master Feb 6, 2015
@beckje01 beckje01 deleted the serializerInterface branch February 6, 2015 01:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants