Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment variable for default text editor #8

Closed
ngosang opened this issue Oct 6, 2021 · 2 comments · Fixed by #10
Closed

Add environment variable for default text editor #8

ngosang opened this issue Oct 6, 2021 · 2 comments · Fixed by #10
Labels
enhancement New feature or request

Comments

@ngosang
Copy link
Contributor

ngosang commented Oct 6, 2021

Following jhuckaby/Cronicle#36 , at some point I had to execute Cronicle CLI..
If you run /opt/cronicle/bin/storage-cli.js edit global/server_groups/0 you get an error: The editor is not set.
You can set this env var in the Dockerfile:
EDITOR=vi
@bluet bluet added the enhancement New feature or request label Oct 12, 2021
@bluet
Copy link
Owner

bluet commented Oct 12, 2021

users can set ENV while docker run, but yes I agree that it won't hurt setting a default ENV.

As most users are not that familiar with vi (more with vim), maybe use pico as default?

@ngosang
Copy link
Contributor Author

ngosang commented Oct 12, 2021 •
edited
Loading

I agree that vi is complicated but pico and nano are not available in the Docker image, just vi

ngosang added a commit to ngosang/docker-cronicle-docker that referenced this issue Oct 12, 2021
@ngosang
Redo Docker image. Resolves bluet#8 Resolves bluet#9
183fca2 
* Update base image. Reduce image size from 398 MB => 148 MB (uncompressed)
* Add environment variable for default text editor. Resolves bluet#8
* Remove /opt/cronicle/logs/cronicled.pid on start. Resolves bluet#9
* Define CRONICLE_VERSION env var
* Move Dockerfile to main folder (good practice)
@ngosang ngosang mentioned this issue Oct 12, 2021
Merged
@bluet bluet closed this as completed in e6a534c Oct 13, 2021
bluet added a commit that referenced this issue Oct 13, 2021
@bluet
Merge pull request #13 from ngosang/feature/editor
f8adbbf 
Add environment variable for default text editor (nano). Resolves #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redo Docker image. Resolves #8 Resolves #9 ngosang/docker-cronicle-docker
2 participants
@bluet @ngosang