Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the fix function back to its odds 0.2.x shape #24

Merged
merged 2 commits into from Nov 27, 2017
Merged

Revert the fix function back to its odds 0.2.x shape #24

merged 2 commits into from Nov 27, 2017

Conversation

bluss
Copy link
Owner

@bluss bluss commented Nov 27, 2017

Self-referential static type closures are not supported by Rust, decided clearly rust-lang/rust/issues/46062

  • This is a technically breaking change in Rust to preserve the soundness of the type system (something like that) and we take the opportunity to mildly break fix to fix it, going back to the previous form.
  • I don't expect any impact at all, because 0.3. is new and nobody is using this cool recursivity combinator anyway.

@bluss
Revert "Improve Fix to not use trait objects using new talchas formul…
49a5e86 
…ation"

Revert because, the new cool implementation of Fix is not allowed; Rust
says we must use dynamic dispatch for this kind of thing. Big <3 to
nikomatsakis for writing such a good explanation of the break.

This reverts commit 814c81f.
@bluss
DOC: Edit fix docs
d8aa0cb
@bluss bluss merged commit ccd90b7 into master Nov 27, 2017
@bluss bluss deleted the restore-fix branch November 27, 2017 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bluss