This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Task/iscroggin/kep 368 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebruck
reviewed
Jun 23, 2018
raft/raft.cpp
Outdated
|
|
||
| for (const auto& peer : this->peers) { | ||
| auto ep = boost::asio::ip::tcp::endpoint{boost::asio::ip::address_v4::from_string(peer.host), peer.port}; | ||
| this->node->send_message(ep, json_ptr); |
There was a problem hiding this comment.
I wouldn't bother with the temporary and construct and endpoint in the send_message call.
ebruck
reviewed
Jun 23, 2018
|
|
||
| void | ||
| audit::start() | ||
| { |
There was a problem hiding this comment.
I like wrapping this in a lambda called by std::call_once
ebruck
reviewed
Jun 23, 2018
audit/audit.cpp
Outdated
| using namespace bzn; | ||
|
|
||
| audit::audit(std::shared_ptr<bzn::node_base> node): node(node) | ||
| { |
There was a problem hiding this comment.
I'd format this as:
audit::audit(...)
: node(node)
{
}
a bit easier to read
There was a problem hiding this comment.
please also use std::move(node)
ebruck
reviewed
Jun 23, 2018
audit/audit.cpp
Outdated
| return this->recorded_errors; | ||
| } | ||
|
|
||
| uint |
ebruck
reviewed
Jun 23, 2018
audit/audit.hpp
Outdated
| const std::list<std::string>& error_strings() const override; | ||
|
|
||
| void handle(const bzn::message& message, std::shared_ptr<bzn::session_base> session) override; | ||
| void handle_commit(const commit_notification&); |
There was a problem hiding this comment.
shouldn't these also be in audit_base?
There was a problem hiding this comment.
My not need the abstract base class if we don't intend to mock this.
ebruck
approved these changes
Jun 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is the changes from last time squashed, second is changes since then.