use a dictionary of labels instead of a string for identifying sets #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why we didn't think of this sooner. Instead of munging useful data into a string an artifact set now is identified by a label dictionary. This is a breaking API change but some convenience was added to still allow strings to be passed in and a
{'name': string_passed_in}is used as the labels.To see this and the related
provenance_setdecorator in action see the new tests:https://github.com/bmabey/provenance/blob/set-labels/tests/provenance/test_core.py#L377-L386
https://github.com/bmabey/provenance/blob/set-labels/tests/provenance/test_core.py#L601-L617