Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and refactor old code #85

Open
bmag opened this issue Feb 21, 2016 · 1 comment
Open

Review and refactor old code #85

bmag opened this issue Feb 21, 2016 · 1 comment
Labels
refactor
Milestone
2.0

Comments

@bmag
Copy link
Owner

bmag commented Feb 21, 2016 •
edited
Loading

Review the existing code, find bits of bad implementation and improve them.
For example, (purpose-flatten (mapcar #'window-list frames)) is bad and should be replaced by (window-list-1 nil nil frames). (edit: window-list-1 doesn't work like this)
@bmag bmag added this to the 2.0 milestone Feb 21, 2016
@bmag bmag added the refactor label Feb 21, 2016
@bmag bmag mentioned this issue May 30, 2018
Closed
wyuenho added a commit to wyuenho/emacs-purpose that referenced this issue Jun 4, 2018
@wyuenho
Fix bmag#85 bmag#86 Remove support for Emacs 24
00163f0 
* autoload `purpose-conf'
* remove purpose-conf instance names
* remove `subr-x' shims
* remove `purpose-alist-get'
* remove old style advice shims
* bump emacs version package requirement
bmag pushed a commit that referenced this issue Aug 9, 2018
@wyuenho @bmag
Fix #85 #86 Remove support for Emacs 24
a60c0ef 
* autoload `purpose-conf'
* remove purpose-conf instance names
* remove `subr-x' shims
* remove `purpose-alist-get'
* remove old style advice shims
* bump emacs version package requirement
@bmag bmag closed this as completed in 2b20dbb Aug 9, 2018
@bmag
Copy link
Owner Author

bmag commented Aug 9, 2018

Automatically closed by commit, but not completely fixed yet so reopen.

@bmag bmag reopened this Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@bmag