Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code by removing support for Emacs 24.3 #86

Closed
bmag opened this issue Feb 21, 2016 · 1 comment
Closed

Simplify code by removing support for Emacs 24.3 #86

bmag opened this issue Feb 21, 2016 · 1 comment
Labels
refactor
Milestone
2.0

Comments

@bmag
Copy link
Owner

bmag commented Feb 21, 2016

Supporting Emacs 24.3 complicates the code in some places, most notable is the existence of purpose-define-compatible-purpose which uses advice-add for 24.4+ and defadvice for 24.3-.

Purpose 2.0 will remove support for 24.3 for the sake of a cleaner codebase. By the time Purpose 2.0 is released, Ubuntu 16.04 will be out and the latest Ubuntu LTS release will have a newer Emacs than 24.3. Thus eliminating the main reason for supporting 24.3.
@bmag bmag added this to the 2.0 milestone Feb 21, 2016
@bmag bmag added the refactor label Feb 21, 2016
wyuenho added a commit to wyuenho/emacs-purpose that referenced this issue Jun 4, 2018
@wyuenho
Fix bmag#85 bmag#86 Remove support for Emacs 24
00163f0 
* autoload `purpose-conf'
* remove purpose-conf instance names
* remove `subr-x' shims
* remove `purpose-alist-get'
* remove old style advice shims
* bump emacs version package requirement
bmag pushed a commit that referenced this issue Aug 9, 2018
@wyuenho @bmag
Fix #85 #86 Remove support for Emacs 24
a60c0ef 
* autoload `purpose-conf'
* remove purpose-conf instance names
* remove `subr-x' shims
* remove `purpose-alist-get'
* remove old style advice shims
* bump emacs version package requirement
bmag pushed a commit that referenced this issue Aug 9, 2018
@wyuenho @bmag
Fix #85 #86 Remove support for Emacs 24
2b20dbb 
* autoload `purpose-conf'
* remove purpose-conf instance names
* remove `subr-x' shims
* remove `purpose-alist-get'
* remove old style advice shims
* bump emacs version package requirement
@bmag
Copy link
Owner Author

bmag commented Aug 9, 2018

Fixed by #129 and its follow-up

@bmag bmag closed this as completed Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@bmag