Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #182 (comment), there seemed to be some recursion caused by using
cl-letf
. Should be fixed by usingcl-flet
.After invoking the debugger (i.e.,
M-x toggle-debug-on-entry RET beginning-of-buffer RET
followed byM-x beginning-of-buffer RET
), repeatedly stepping through (by pressingd
) would recurse into our advice every time. I wasn't able to recreate the same recursion (with other test functions) outside of the debugger environment, so there is probably be another mysterious factor in the debugger that triggers the recursion.