Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multisite Network Setttings #85

Closed
afragen opened this issue Oct 18, 2014 · 10 comments
Closed

Multisite Network Setttings #85

afragen opened this issue Oct 18, 2014 · 10 comments

Comments

@afragen
Copy link
Contributor

afragen commented Oct 18, 2014

I've been working on this and I've got it working so if the user has Zero Spam network enabled then settings for all sites in the multisite can be set under the Network Admin. It still works in a single site install. My problem is if the plugin is not network enabled the settings aren't saving in the subsites.

I'm still working on this.

@afragen
Copy link
Contributor Author

afragen commented Oct 18, 2014

It seems that $_POST isn't being set.

@bmarshall511
Copy link
Collaborator

@afragen Thanks for working on this, it'll be great to have.

@afragen
Copy link
Contributor Author

afragen commented Oct 21, 2014

@bmarshall511 you're changing the structure of the plugin way too fast for me to keep up with getting multisite to work.

@bmarshall511
Copy link
Collaborator

@afragen Ah, my bad. Sorry about that. I'll keep it stagnant for awhile so you can get your changes in.

@afragen
Copy link
Contributor Author

afragen commented Oct 21, 2014

Right now I'm having issues with the settings not displaying under network activated and for some strange reason when I switch get_option to get_site_option and update_option to update_site_option, my options save in network activate but not in sub site activate.

Still working...

@afragen
Copy link
Contributor Author

afragen commented Oct 21, 2014

Can you take a look at https://github.com/afragen/wordpress-zero-spam/tree/multisite ?

Issues

  1. Settings page doesn't seem to display properly under Network Activation for me. It used to so I don't understand why general-settings.tpl.php isn't rendering here.
  2. Using get_site_option and update_site_option should give the same results but saving in sub site but it doesn't. It does save correctly with used in WordPress single install.

I have some time tomorrow to keep testing.

@afragen
Copy link
Contributor Author

afragen commented Oct 21, 2014

css-dev and js-dev and containing files are still referenced and I always have WP_DEBUG set.

@afragen
Copy link
Contributor Author

afragen commented Oct 21, 2014

Somewhere between 1.5.0 and 1.5.2 something changed and settings page doesn't call general-settings.tpl.php correctly. Trying to debug that now.

@afragen
Copy link
Contributor Author

afragen commented Oct 21, 2014

Woot! Some fixes, including fixing a stupid mistake on my part. #94

@bmarshall511
Copy link
Collaborator

@afragen merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants