FIX bash exec failure when the etc directory is missing
#192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add the `etc` directory (containing `.keep.README.md`) - note: the `.keep.README.md` file is a prompt for git to store the otherwise empty directory * fixes bmatzelle#65, bmatzelle#127, and bmatzelle#180 .# DISCUSSION This commit builds upon the fix for the same problem done in bmatzelle/gow@21710c6 by adding the `etc` directory into the repo. This makes the repo usable when installed as portable app (eg, via `scoop`) without requiring extra post installation steps.
|
Thanks. I'll review. |
rivy
added a commit
to rivy/scoop
that referenced
this pull request
Jul 2, 2015
* create the `etc` directory (if needed) .# DISCUSSION `bash` requires the `etc` directory for startup. However, `etc` is missing from the GOW repo. There are current pull requests fixing this issue (see bmatzelle/gow#192). But, this fixes the the issue while waiting for the GOW repo to be updated. The fix here is compatible with all of the current possible future GOW repo fixes.
|
This seems very popular functionality that to be implemented )). See also my commit d30c159. |
|
Annual bump... any thoughts on closing this via merging or refusing? |
|
As with most pull requests I can't just take it as-is. I started working on it and got stuck so I haven't gotten back to it. I don't know when I'll be able to resume work on it again. |
|
Can you define the issue? I'm happy to refactor the PR, if needed. |
|
It's been months. I'll have to review. The biggest issue was that there are multiple fixes for this issue but everyone has a different implementation. I was trying to choose the best version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etcdirectory (containing.keep.README.md).keep.README.mdfile is a prompt for git to store the otherwise empty directory.# DISCUSSION
This commit builds upon the fix for the same problem in 21710c6 by adding the
etcdirectory into the repo. This makes the repo usable when installed as portable app (eg, viascoop) without requiring extra post installation steps.