Dependency and CI update

[fmartingr]

Go updates

• Updated to go 1.20
• Updated all dependencies

Test fixes

• Updated sample files and URLs
• Added testify/require in some non-checked scenarios
• Updated some old references to ioutil only in the tests I modified

CI updates

• Upgraded all actions to their latest versions
• Tests are only done in the go version set up in the go.mod file.

[coveralls]

coverage: 86.799%. remained the same when pulling c4e0409 on fmartingr:update-dependencies-and-ci into 5d94be3 on bmaupin:main.

[bmaupin]

Thanks for your contribution!

(I cleaned up my comments to reduce confusion. See the code review below)

[owulveryck]

I am on vacation with limited access, but from what I see I fully agree with you @bmaupin especially on the maintenance of the CI dependencies (with the commit numbers).
On the other hand, I think this PR is mandatory, as the CI and dependencies needs some updates.

[bmaupin]

I've been out of the Go world so long, I didn't realize that updating dependencies would force the version of Go in this project to be updated as well. So that explains many of the changes here.

I guess that technically still counts as a breaking change; if it means the library would require Go 1.20, then I guess we'd need to bump the major version of this library to v2. Which shouldn't be too big of a deal, it's just a version number :)

I'll try to address any remaining issues by adding code reviews.

[fmartingr]

As general comment, I think is best if an http server is used during the tests for the URL downloads rather than downloading files from the internet, but I don't think you want me to address a change like that here?

[bmaupin]

As general comment, I think is best if an http server is used during the tests for the URL downloads rather than downloading files from the internet, but I don't think you want me to address a change like that here?

I agree 100%. Yes, for now I think we can limit the changes to fixing the tests and upgrading dependencies. Once that's done, I think it would be a great idea to use an HTTP server during the tests. That would prevent broken URLs from breaking the tests in the future. Feel free to submit a PR for it if you'd like.

[fmartingr]

I have fully reverted the changes to tests (because now the URLs works for me? Don't know what happened, but tests where failing for me on requests 🤷). I can do separate PRs to move the tests to an http server and to fix all deprecations being used, maybe even add a golangci-lint to actions as well.

[bmaupin]

I have fully reverted the changes to tests (because now the URLs works for me? Don't know what happened, but tests where failing for me on requests shrug). I can do separate PRs to move the tests to an http server and to fix all deprecations being used, maybe even add a golangci-lint to actions as well.

Thanks so much, that sounds great! Thanks for your contribution!