Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLUtil.textFromHTML(...) returns all "-" signs twice #8

Closed
McPringle opened this issue Apr 2, 2012 · 4 comments
Closed

HTMLUtil.textFromHTML(...) returns all "-" signs twice #8

McPringle opened this issue Apr 2, 2012 · 4 comments

Comments

@McPringle
Copy link

Hello Brian,

there is a new bug in this method. The "-" signs are now repeated. I wrote a simple unit test so you can see, what I mean:

Assert.assertEquals( "this is a foo-bar test", HTMLUtil.textFromHTML( "this is a foo-bar test" ) );

This test fails because the method returns: "this is a foo--bar test"

Thanks for your really good work!

@bmc
Copy link
Owner

bmc commented Apr 2, 2012

I'll take a look at this, probably sometime today.

@McPringle
Copy link
Author

Simply remove line 382. That fixes this problem. A single, short hyphen should not be replaced by two dashes, I think.

@bmc
Copy link
Owner

bmc commented Apr 2, 2012

Fixed in version 3.1.1, just released.

@bmc bmc closed this as completed Apr 2, 2012
@McPringle
Copy link
Author

Works perfekt in version 3.1.1, thanks a lot for your fast fixing and great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants