Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for travis ci and tox #32

Merged
merged 2 commits into from
Oct 12, 2016
Merged

Conversation

aragilar
Copy link
Collaborator

@aragilar aragilar commented Oct 2, 2016

This adds support for two testing utilities, tox and travis ci.

@bmcage bmcage merged commit 6aa7a27 into bmcage:master Oct 12, 2016
@bmcage
Copy link
Owner

bmcage commented Oct 12, 2016

Ok, I'm looking into moving to sundials 2.7.0 in light of the release. But it seems the code here does not redownload sundials?

export SUNDIALS_DIR=$HOME/sundials
SUNDIALS_LIBDIR=$SUNDIALS_DIR/lib
SUNDIALS_INCLUDEDIR=$SUNDIALS_DIR/include

if [ ! -d "$SUNDIALS_LIBDIR" ]; then
    mkdir -p $SUNDIALS_DIR
    echo "Installing sundials"
    ./ci_support/install_sundials.sh
else
    echo "Using cached sundials"
fi

Not sure how Travis works. It seems with a cached version, so how to remove that on new sundials version?

@bmcage
Copy link
Owner

bmcage commented Oct 12, 2016

I see only version in include/sundials_config.h.
Perhaps we should set here

export SUNDIALS_DIR=$HOME/sundials

to

export SUNDIALS_DIR=$HOME/sundials_2.7.0

then when 2.7.1 is released change this again. Good approach?

@aragilar aragilar deleted the add_travis branch October 12, 2016 23:35
@aragilar
Copy link
Collaborator Author

Yeah, I wasn't expecting the 2.7 release (as I'd hardcoded many things), I've now added proper support for choosing the sundials version on travis (see #34). You may need to clear the cache before merging, but it should now be possible to choose which version to use just by modifying the .travis.yml file.

Also, Debian may soon have sundials 2.7, see https://lists.debian.org/debian-science/2016/10/msg00023.html and the rest of the thread (updating without dropping octave-sundials was one of the main reasons that I haven't finished updating sundials).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants