Fix issue with no set Day of Week #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this PR seems to fix the issue. I applied the changes, restarted HA and within a few seconds of HA fully booting, the chore sensors were updated with the appropriate values, no need to re-complete the chore! |
|
Thanks so much, and sorry for the delay. Thanks looks good to me, I will get it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes an issue with the chore_weekly candidate selection.
Without the PR, if no weekday is set, it is used without checking if it is
None, and likely doesn't select an appropriate date.The PR checks if a chore day is set. If it is, it uses it. If not, it just uses the day of the week of the start_date (which I think corresponds to the last completed date).
I believe this should fix #32, but I welcome more testing / reviews.