Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked down 'pegjs' and 'uglify-js' dependencies. #210

Merged
merged 1 commit into from
May 9, 2017

Conversation

CodeLenny
Copy link
Contributor

Hey Blake,

I noticed uglify-js v3 was just released, which includes breaking changes.
I didn't look through the changes, but they broke the middleware serving /blade/blade.js, as well as tmpl.toString(), which now returns undefined:

blade._cachedViews["IDE.blade"]=undefined;var e=blade._cb["IDE.blade"];e&&e(null,".",[],false);

While creating the fork to specify the uglify-js version number, I found that pegjs removed the --track-line-and-column option in version 0.8.0 (4th item in the big changes), so I locked pegjs down as well.

I converted your version numbers from greater-than >=2.2.3 to caret syntax (^2.2.3). I can convert them back to version ranges if they were specified with greater-than for a reason, or if you just prefer that syntax.

Thanks,
Ryan

@bminer bminer merged commit ff71337 into bminer:master May 9, 2017
@bminer
Copy link
Owner

bminer commented May 9, 2017

Thanks!

@CodeLenny
Copy link
Contributor Author

@bminer Thank you for merging so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants