Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test coverage check #26

Closed
bmish opened this issue Oct 1, 2022 · 1 comment · Fixed by #287
Closed

Fix test coverage check #26

bmish opened this issue Oct 1, 2022 · 1 comment · Fixed by #287
Labels
internal

Comments

@bmish
Copy link
Owner

bmish commented Oct 1, 2022

Jest is not indicating why function test coverage is not at 100%. We want all coverage to be 100%.

eslint-doc-generator/jest.config.cjs

Line 21 in 83563c5

functions: 96.77, // TODO: Should be 100% but unclear what function is missing coverage.

@bmish bmish added the internal label Oct 1, 2022
@bmish
Copy link
Owner Author

bmish commented Oct 5, 2022 •
edited

It looks like this is being caused by the transient mock-fs test fixture files showing up in the test coverage report.

We need to ignroe these transient files. We might have to move the test fixture files to a directory and ignore it with coveragePathIgnorePatterns.

@bmish bmish changed the title Figure out what function is missing test coverage Fix test coverage check Oct 6, 2022
@bmish bmish mentioned this issue Nov 26, 2022
Merged
bmish added a commit that referenced this issue Nov 26, 2022
@bmish
Merge pull request #287 from G-Rath/enable-full-coverage
9b15f1b 
Fixes #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require full function coverage
1 participant
@bmish