Require full function coverage #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, can you mark it as "Fixes #26". I have some more details in that issue as well. |
ddzz
approved these changes
Nov 26, 2022
bmish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also the reason why Jest always updates your snapshots locally instead of erroring about them being different, because Jest can't actually load the original snapshots but writes are apparently happening to the real disk - this isn't the end of the world because Jest automatically freezes snapshots when running in CI so you'll still get told if a snapshot needs updating and then that update will be in the diff for inspection.
(
also looks like linting is not applying to this file for some reason, but that's another PRok so linting is, but its wanting different formatting than for all the other files? 馃)Fixes #26