Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether path is a valid git folder #181

Closed
wants to merge 7 commits into from

Conversation

bearzk
Copy link
Contributor

@bearzk bearzk commented Feb 21, 2018

before running all calculation against it.

It runs 2 git commands to see if the folder
is a git folder and if it contains commits.

before running all calculation against it.

It runs 2 git commands to see if the folder
is a git folder and if it contains commits.
@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #181 into master will decrease coverage by 2.75%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #181      +/-   ##
============================================
- Coverage     76.32%   73.57%   -2.76%     
- Complexity      109      113       +4     
============================================
  Files            17       17              
  Lines           321      333      +12     
============================================
  Hits            245      245              
- Misses           76       88      +12
Impacted Files Coverage Δ Complexity Δ
src/Results/ResultCollection.php 100% <ø> (ø) 6 <0> (ø) ⬇️
src/Managers/ProcessManager.php 0% <ø> (ø) 8 <0> (ø) ⬇️
src/Logic/ResultsLogic.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Results/Result.php 96% <ø> (ø) 6 <0> (ø) ⬇️
src/Collections/FileCollection.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Results/ResultsParser.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Commands/ChurnCommand.php 0% <0%> (ø) 10 <3> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef1d65...e30e645. Read the comment docs.

@villfa
Copy link
Collaborator

villfa commented Nov 13, 2020

Thank you for the work.

I'm closing it since #257 and #260 fix the same problem.

@villfa villfa closed this Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants