Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the "commitsSince" validator #362

Merged
merged 2 commits into from
Sep 18, 2022
Merged

Conversation

villfa
Copy link
Collaborator

@villfa villfa commented Sep 17, 2022

Fixes #360

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #362 (0b3f3d0) into master (c67da4b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   98.94%   98.96%   +0.01%     
==========================================
  Files          56       56              
  Lines         854      867      +13     
==========================================
+ Hits          845      858      +13     
  Misses          9        9              
Impacted Files Coverage Δ
src/Configuration/Validator/CommitsSince.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villfa villfa force-pushed the fix/360 branch 5 times, most recently from 1a886cf to ab2905f Compare September 17, 2022 23:18
Copy link

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it! But also, way better PR then you would've gotten out of me 😅 Thanks for the quick fix.

@villfa villfa merged commit dd1ac6c into bmitch:master Sep 18, 2022
@villfa villfa deleted the fix/360 branch September 18, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"commitsSince" not recognized
2 participants