Provide ipv6 address support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For class kademlia.network.Server: change listen(port) ---> listen(port, interface=None). interface="::" can be provided to enable ipv6 support.
| @@ -40,15 +40,20 @@ def __init__(self, ksize=20, alpha=3, id=None, storage=None): | |||
| self.protocol = KademliaProtocol(self.node, self.storage, ksize) | |||
| self.refreshLoop = LoopingCall(self.refreshTable).start(3600) | |||
|
|
|||
| def listen(self, port): | |||
| def listen(self, port, interface=None): | |||
There was a problem hiding this comment.
If you use interface='' as the default, then line 51 can just be return reactor.listenUDP(port, self.protocol, interface=interface) and you won't need any of the other lines.
Changed default interface to ""
|
changed |
|
Version bumped as well on pypi. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For class kademlia.network.Server:
change
listen(port)to
listen(port, interface=None)interface="::"can be provided to enable ipv6 support.This is in accordance with as given in twisted documentation