This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Make type-checks 'future compatible' by using isinstance #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously type-checks were done by doing type(obj) is klass This doesn't take into account 'future' libs that use object inheritance to backport new features from 3 to 2 without breaking 2-only libs. Now type-checks are done using 'isinstance', which is a more relaxed type-check, but also the desired behavior typically.
|
@bmuller Let me know once you're merged and pushed up to pypi; afaik same tests pass & run |
|
v1.5 now available on pypi |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously type-checks were done by doing
type(obj) is klass
This doesn't take into account 'future' libs that use object inheritance to
backport new features from 3 to 2 without breaking 2-only libs. Now type-checks
are done using 'isinstance', which is a more relaxed type-check, but also the
desired behavior typically.